Conversation
justasm
commented
Dec 7, 2020
| this.delegate = delegate | ||
| } | ||
|
|
||
| data class Event(val business: RawEvent?, val publish: RawEvent) |
Member
Author
There was a problem hiding this comment.
business should not be nullable
eimantas
reviewed
Dec 7, 2020
| } | ||
|
|
||
| @ThreadLocal | ||
| object Analytics { |
Contributor
There was a problem hiding this comment.
It would be great to have all these properties and functions static. In Swift we consume events through a static method: Analytics.consume(event). Currently the generated interface requires to instantiate the Analytics type and call methods from there.
Member
Author
There was a problem hiding this comment.
Please experiment to see what Kotlin code gives you the result you expect. Ping me if you'd like to brainstorm ideas together.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those with access to Trafi's internal VPN can access & edit the event schema via the Mammoth editor.
Uses https://github.com/trafi/mammoth-kt to generate type-safe analytics events from the schema.
Any UI component can call
Analytics.consume(AnalyticsEvent.$eventName()). By default, events go nowhere. Any SDK consumer can register anAnalyticsDelegateto do something with the events.